feat(2.9): deprecate ResetDatabase trait
#985
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
ResetDatabase trait
nikophil
force-pushed
the
feat/attribute-for-reset-database-2
branch
from
43f4a0b to
91dd0a7
Compare
nikophil
force-pushed
the
feat/attribute-for-reset-database-2
branch
from
91dd0a7 to
a3f404b
Compare
nikophil
force-pushed
the
feat/attribute-for-reset-database-2
branch
3 times, most recently
from
1ec9784 to
4272d7d
Compare
nikophil
force-pushed
the
feat/attribute-for-reset-database-2
branch
2 times, most recently
from
8a6d6df to
3721f01
Compare
nikophil
force-pushed
the
feat/attribute-for-reset-database-2
branch
6 times, most recently
from
f898cd3 to
f48fbd2
Compare
nikophil
commented
Oct 11, 2025
| public function boot(): void | ||
| { | ||
| if ($this->container) { | ||
| if ($this->container && (!Configuration::isBooted() || !FoundryExtension::isEnabled())) { |
There was a problem hiding this comment.
@HypeMC, just for you to know:
now we're deprecating the usage of ResetDatabase trait in favor of an attribute + usage of the PHPUnit extension, I had errors ServiceNotFoundException: The "kernel" service is synthetic, it needs to be set at boot time before it can be used. in the database reset testsuite.
Because this currently needs to work with and without the ResetDatabase trait, the only solution I found was to check if the extension is enabled.
Don't hesitate if you have another idea. Anyway, this ugly stuff will be removed in Foundry 3
nikophil
force-pushed
the
feat/attribute-for-reset-database-2
branch
from
f48fbd2 to
a8279d8
Compare
nikophil
force-pushed
the
feat/attribute-for-reset-database-2
branch
from
bbeb282 to
874ce5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.